Fix flakey integ test by adding params#7146
Merged
RanVaknin merged 1 commit intoJul 20, 2026
Merged
Conversation
RanVaknin
marked this pull request as ready for review
July 14, 2026 21:58
RanVaknin
commented
Jul 15, 2026
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
| import static software.amazon.awssdk.testutils.service.AwsTestBase.isValidSdkServiceException; |
RanVaknin
commented
Jul 15, 2026
| import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider; | ||
| import software.amazon.awssdk.core.CompressionConfiguration; | ||
| import software.amazon.awssdk.core.SdkGlobalTime; | ||
| import software.amazon.awssdk.core.exception.SdkServiceException; |
S-Saranya1
approved these changes
Jul 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Jul 17, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
testExceptionHandlinginteg test in the Cloudwatch test package was flakey because the service was returning a non deterministic exception. We expected it to returnMissingParameterexception but it sometimes returnedInvalidParameterCombinationexception instead.I was able to reproduce it by running test case repeatedly 100 times, seeing the following:
79/100
MissingParameter21/100
InvalidParameterCombinationFix
The fix adds all the other required fields, except for
MetricName. Resulted in deterministic 100/100MissingParameterexception.